Uploaded image for project: 'Active and Available Inventory'
  1. Active and Available Inventory
  2. AAI-454

LoggingContext.requestId required NULL handling in aai/aai-common (20170607) - during demo.sh init_customer

    Details

    • Type: Bug
    • Status: Closed
    • Priority: High
    • Resolution: Done
    • Affects Version/s: Amsterdam Release
    • Fix Version/s: Amsterdam Release
    • Labels:

      Description

       Moved to AAI

      We need to fix this immediately

      https://lists.onap.org/pipermail/onap-discuss/2017-November/006122.html

       No tracking JIRA for change in aai/aai-common 2017-06-07

      https://gerrit.onap.org/r/#/c/4787/

      https://gerrit.onap.org/r/#/c/4787/1/aai-core/src/main/java/org/openecomp/aai/logging/LoggingContext.java

       

      [AAI-ONAP] Get the latest code and sync to onap
      
      Change-Id: Ifd6e05a807b1bc5246cd2442cb54495b84100e83
      Signed-off-by: Venkata Harish K Kajur <vk250x@att.com>

       original LOG-70

      Fyi,

         The following works out of the box on the 20171004:0800 tag of ONAP deployed to OOM – AAI is working if you have a prepopulated region – or you previously do a PUT request

       

      PUT on

      https://aai_ip:aai_port/aai/v8/cloud-infrastructure/cloud-regions/cloud-region/IAD/RegionOne

      GET on

      https://aai_ip:aai_port/aai/v11/cloud-infrastructure/cloud-regions/

       

      {    "cloud-region": [

              {

                  "cloud-owner": "IAD",

                  "cloud-region-id": "RegionOne",

                  "cloud-type": "SharedNode",

                  "owner-defined-type": "OwnerType",

                  "cloud-region-version": "v1",

                  "cloud-zone": "CloudZone",

                  "sriov-automation": false,

                  "resource-version": "1507147808029"

              } ]}

       

      The NPE looks like a separate bug where the requestId String passed into the static log function is not null checked

      org.onap.aai.logging.LoggingContext:117 

      If(requestId.contains(“:”)

      Should be

      If(null != requestId && requestId.contains(“:”)

       

      Since the IAE catch block will not generate a UUID for a null requestId

       

      I’ll put in a JIRA to AAI – this is log related

       

      java.lang.NullPointerException: null

                      at org.onap.aai.logging.LoggingContext.requestId(LoggingContext.java:119)

      Thank you

      /michael

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              • Assignee:
                vk250x Venkata Harish Kajur
                Reporter:
                michaelobrien Michael O'Brien
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: