Uploaded image for project: 'Data Movement as a Platform'
  1. Data Movement as a Platform
  2. DMAAP-923

[DR] DMaaP-DR Node NodeServlet refactoring

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Done
    • Icon: Medium Medium
    • El Alto Release
    • None
    • None

      When I was trying do debug or determine what might have gone wrong in DFC E2E flow, I found out, that in NodeServlet we (people from Nokia) could do some improvements in NodeServlet.

      My proposal is:

      1. Fix logging as current logs do not provide sufficient information
      2. Refactor private void common(HttpServletRequest req, HttpServletResponse resp, boolean isput) as it has 237 lines of code into smaller functions
      3. Add positive case for JUnit tests  - I have found only negative scenarios

       
      How to check if we do not break anything:

      1. Gerrit ticket blocks direct merge to master
      2. Existing JUnit tests provide regression against locally fired tests
         

      Condition Of Satisfaction [COS]:
           CSIT is green for DMaaP DR

       

            Unassigned Unassigned
            mmigdal mmigdal
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: