-
Task
-
Resolution: Done
-
Low
-
None
-
None
-
OOM-Offline Sprint 3
There are bunch of warnings reported by ansible-lint check:
https://jenkins.onap.org/sandbox/job/offline-installer-master-yaml-lint/4/console
scope of this task is to fix those:
602 Don't compare to empty string
/w/workspace/offline-installer-master-yaml-lint/ansible/roles/application-install/tasks/custom_role.yml:9
- application_custom_role | trim != ''
301 Commands should not change things if nothing needs doing
/w/workspace/offline-installer-master-yaml-lint/ansible/roles/application-install/tasks/install.yml:2
Task/Handler: Helm init and upgrade
301 Commands should not change things if nothing needs doing
/w/workspace/offline-installer-master-yaml-lint/ansible/roles/application-install/tasks/install.yml:10
Task/Handler: Wait for helm upgrade to finish
301 Commands should not change things if nothing needs doing
/w/workspace/offline-installer-master-yaml-lint/ansible/roles/application-install/tasks/install.yml:17
Task/Handler: Get all helm repos
301 Commands should not change things if nothing needs doing
/w/workspace/offline-installer-master-yaml-lint/ansible/roles/application-install/tasks/install.yml:25
Task/Handler: Helm Serve
301 Commands should not change things if nothing needs doing
/w/workspace/offline-installer-master-yaml-lint/ansible/roles/application-install/tasks/install.yml:30
Task/Handler: Helm Add Repo
206 Variables should have spaces before and after: {{ var_name }}
/w/workspace/offline-installer-master-yaml-lint/ansible/roles/application-install/tasks/install.yml:50
dest: "{{ app_data_path}}/override.yaml"
301 Commands should not change things if nothing needs doing
/w/workspace/offline-installer-master-yaml-lint/ansible/roles/application-install/tasks/install.yml:61
Task/Handler: Helm Install application {{ app_name }}
503 Tasks that run when changed should likely be handlers
/w/workspace/offline-installer-master-yaml-lint/ansible/roles/certificates/tasks/upload_root_ca.yml:9
Task/Handler: Extract root certificate
502 All tasks should be named
/w/workspace/offline-installer-master-yaml-lint/ansible/roles/nexus/tasks/insert-images.yml:4
Task/Handler: set_fact component={{ (item.path | basename | splitext)[0] }} _file=/w/workspace/offline-installer-master-yaml-lint/ansible/roles/nexus/tasks/insert-images.yml __line_=5
204 Lines should be no longer than 160 chars
/w/workspace/offline-installer-master-yaml-lint/ansible/roles/resource-data/tasks/unarchive-nfs-resource.yml:19
- name: "Unarchive resource {{ resources_dir }}/{{ resource_source_filename }} to {{ resource_destination_directory }} dir on infrastructure servers over nfs"
502 All tasks should be named
/w/workspace/offline-installer-master-yaml-lint/ansible/roles/resource-data/tasks/unarchive-resource.yml:37
Task/Handler: file state=touch path={{ resource_destination_directory }}/{{ resource_source_filename }}-uploaded _file=/w/workspace/offline-installer-master-yaml-lint/ansible/roles/resource-data/tasks/unarchive-resource.yml __line_=38
502 All tasks should be named
/w/workspace/offline-installer-master-yaml-lint/ansible/roles/resource-data/tasks/unarchive-resource.yml:54
Task/Handler: fail msg=Upload of {{ resource_source_filename }} failed _file=/w/workspace/offline-installer-master-yaml-lint/ansible/roles/resource-data/tasks/unarchive-resource.yml __line_=55
204 Lines should be no longer than 160 chars
/w/workspace/offline-installer-master-yaml-lint/ansible/roles/resource-data/tasks/unarchive-ssh-resource.yml:32
- name: "Unarchive resource {{ resources_dir }}/{{ resource_source_filename }} to {{ resource_destination_directory }} dir on infrastructure servers over ssh"