Uploaded image for project: 'Policy Framework'
  1. Policy Framework
  2. POLICY-3929

Race condition in apex-editor model upload

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Medium
    • Resolution: Done
    • Guilin Release, Honolulu Release, Istanbul Release, Jakarta Release
    • Jakarta Release
    • gui
    • None

    Description

      This bug was previously documented in POLICY-2853, but never fixed.

      The code takes in a request parameter and stores it in a global variable:

      public ApexApiResult uploadModel(@QueryParam("userId") final String userid) {
    if (!StringUtils.isBlank(userid)) {
        ApexEditorMain.getParameters().setUploadUserid(userid);
    }
    return processRestCommand(RestCommandType.MODEL, RestCommand.UPLOAD);
}

      Thus if two users upload at the same time, one userId may overwrite the other.

      An appropriate fix would be to use userId param only for this request if specified, otherwise use the upload-userid command line param specified at apex-editor startup. This will work as ApexFiles.js sets the userId param for each upload request:

      function files_fileUpload() {
    let requestURL = window.restRootURL + "/Model/Upload";
    const userId = new URLSearchParams(window.location.search).get('userId');
    if (userId) {
        requestURL = requestURL + "?userId=" + userId;
    }
    // ...
}

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. POLICY-2853 Make APEX editor userId thread safe

          • Medium - Failure of non-critical aspects of the system but results in an inconvenient situation. It causes some undesirable behavior, but the system is still functional. There is a reasonably satisfactory workaround. It is still a valid defect that should be corrected May be fixed after the release or in the next release.
          • Closed
          # Subject Branch Project Status CR V
          127099,1 Fix race condition in apex-editor model upload master policy/gui Status: MERGED +2 +1

          Activity

            People

              danielhanrahan Daniel Hanrahan
              danielhanrahan Daniel Hanrahan
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: