Uploaded image for project: 'Service Orchestrator'
  1. Service Orchestrator
  2. SO-3375

FlowManipulatorListenerRunner does not invoke for controller execution config-deploy

XMLWordPrintable

      environment:
      pnf registration
      mariadb with entries ControllerExecution config-assign and ControllerExecution config-deploy
      skipPostConfiguration set to true

      problem:

      The problem is in WorkflowActionBBTasks class, in the method selectBB, in the following line:
      flowManipulatorListenerRunner.modifyFlows(flowsToExecute, new DelegateExecutionImpl(execution));

      The current FlowManipulatorListenerRunner implementation has defect.

      The issue is that FlowManipulatorListenerRunner finds that there is FlowManipulator (SkipCDSBuildingBlockListener) for ControllerExecution config-assign. Then the logic of SkipCDSBuildingBlockListener is invoked and this bb is skipped, because skipPostConf flag is set to true.
      This is correct behavior.
      But the same logic should be invoked for ControllerExecution config-deploy, but it is not, because after skipping config-assign, the flow goes forward and config-deploy is invoked.

      The method modifyFlows in FlowManipulatorListenerRunner should be changed like that:

      • if I run FlowManipulator for ControllerExecution config-assign, then I should also invoke the same code for config-deploy

            lukaszm lukaszm
            lukaszm lukaszm
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: