Uploaded image for project: 'Active and Available Inventory'
  1. Active and Available Inventory
  2. AAI-2433

[Refactoring] - Review code quality of aai-core and address problems

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Done
    • Icon: Lowest Lowest
    • London Release
    • None

      aai-core has obvious code quality problems. For example:

      • POJO classes access spring context via SpringContextAware
      • mixing POJOs and spring beans haphazardly
      • dependency management (use introspection and you get DMAAP logging! voilĂ !)
      • everything in namespace "org.onap.aai"
      • undocumented classes (no description what their purpose is, you need to study the code) and properties (you need to chase properties in code to understand what they set)
      • code structure (nested if-s to the 4th level and beyond)
      • authentication referenced in separate ticket AAI-2432
      • source code not available via nexus (as this is "core" I would expect it to be available)
      • design done without java generics (although they are available since 2004)
      • the above is just scratching the surface ...

      Code should be reviewed and fixed, unfortunately no amount of "unit tests" will help here.

      I would advice (if possible of course) to have the review done by devs outside the team that created this project (maybe ask Huawei, Amdocs..?). I think the effort would be worth as this is "core" functionality.

            Unassigned Unassigned
            wageslave wageslave
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: