Uploaded image for project: 'Active and Available Inventory'
  1. Active and Available Inventory
  2. AAI-569

Fix Sonar issues for AAI (Active and Available Inventory)

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Closed
    • Priority: Lowest
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: Dublin Release
    • Labels:

      Description

      Story created for fixing SONAR defects.

        Attachments

          Issue Links

          1.
          Sonar Major : Remove useless parentheses. Sub-task Closed Aishwarya Singh
          2.
          To either Log or rethrow exception Sub-task Closed Aishwarya Singh
          3.
          Make field final static Sub-task Closed Aishwarya Singh
          4.
          To either Log or rethrow exception Sub-task Closed Aishwarya Singh
          5.
          Remove the declaration of runtime exception Sub-task Closed Aishwarya Singh
          6.
          Define a constant instead of duplicating this literal "model-elements" 8 times. Sub-task Closed Aishwarya Singh
          7.
          Define a constant instead of duplicating this literal "relationship-list" Sub-task Closed Aishwarya Singh
          8.
          Remove the declaration of thrown exception Sub-task Closed Aishwarya Singh
          9.
          Use isEmpty() to check whether the collection is empty or not Sub-task Closed Aishwarya Singh
          10.
          Remove duplicate literal Sub-task Closed Aishwarya Singh
          11.
          Replace the type specification in constructor call with the diamond operator. Sub-task Closed Aishwarya Singh
          12.
          Add the "@Override" annotation . Sub-task Closed Aishwarya Singh
          13.
          Remove parenthesis Sub-task Closed Aishwarya Singh
          14.
          Remove those useless parentheses Sub-task Closed Aishwarya Singh
          15.
          Remove redundant "static" qualifier. Sub-task Closed Aishwarya Singh
          16.
          Add the "@Override" annotation above method signature Sub-task Closed Aishwarya Singh
          17.
          Add the "@Override" annotation. Sub-task Closed Aishwarya Singh
          18.
          Add the "@Override" annotation above method . Sub-task Closed Aishwarya Singh
          19.
          Make this final field static. Sub-task Closed Aishwarya Singh
          20.
          Add the "@Override" annotation above method signature. Sub-task Closed Aishwarya Singh
          21.
          Add the "@Override" annotation above method signature. Sub-task Closed Aishwarya Singh
          22.
          Add the "@Override" annotation. Sub-task Closed Aishwarya Singh
          23.
          Add the "@Override" annotation above method signature. Sub-task Closed Aishwarya Singh
          24.
          Define a constant instead of duplicating this literal "Content-Type" 3 times. Sub-task Closed Aishwarya Singh
          25.
          Add the "@Override" annotation above this method signature. Sub-task Closed Aishwarya Singh
          26.
          Add the "@Override" annotation above this method signature. Sub-task Closed Aishwarya Singh
          27.
          Add the "@Override" annotation above this method signature. Sub-task Closed Aishwarya Singh
          28.
          Replace the type specification in this constructor call with the diamond operator ("<>"). Sub-task Closed Aishwarya Singh
          29.
          Remove the declaration of thrown runtime exception. Sub-task Closed Aishwarya Singh
          30.
          Remove the declaration of thrown runtime exception . Sub-task Closed Aishwarya Singh
          31.
          Replace the type specification in this constructor call with the diamond operator ("<>"). Sub-task Closed Aishwarya Singh
          32.
          Annotate the "IModelParser" interface with the @FunctionalInterface annotation . Sub-task Closed Aishwarya Singh
          33.
          Replace the type specification with the diamond operator . Sub-task Closed Aishwarya Singh
          34.
          Add the "@Override" annotation. Sub-task Closed Aishwarya Singh
          35.
          Merge if statement with the enclosing one. Sub-task Closed Aishwarya Singh
          36.
          Add the "@Override" annotation above this method signature. Sub-task Closed Aishwarya Singh
          37.
          Replace the type specification with the diamond operator. Sub-task Closed Aishwarya Singh
          38.
          Replace the type specification in this constructor call with the diamond operator . Sub-task Closed Aishwarya Singh
          39.
          Define a constant instead of duplicating this literal "depth" . Sub-task Closed Aishwarya Singh
          40.
          Sonar Define a constant instead of duplicating this literal. Sub-task Closed Aishwarya Singh
          41.
          Define a constant instead of literal. Sub-task Closed Aishwarya Singh
          42.
          Sonar Define a constant instead of duplicating this literal . Sub-task Closed Aishwarya Singh
          43.
          The block of commented-out lines of code should be removed. Sub-task Closed Aishwarya Singh
          44.
          Add the "@Override" annotation above method signature. Sub-task Closed Aishwarya Singh
          45.
          Replace the type specification in this constructor call with the diamond operator . Sub-task Closed Aishwarya Singh
          46.
          Add the "@Override" annotation above this method signature. Sub-task Closed Aishwarya Singh
          47.
          Replace the type specification in this constructor call with the diamond operator. Sub-task Closed Aishwarya Singh
          48.
          Make this final field static too. Sub-task Closed Aishwarya Singh
          49.
          Sonar major:Move the "aai-internal" string literal on the left side of this string comparison for aai-traversal Sub-task Closed Swapnali Pode
          50.
          Replace the type specification in this constructor call with the diamond operator. Sub-task Closed Aishwarya Singh
          51.
          Remove this unused import 'java.util.ArrayList' Sub-task Closed Swapnali Pode
          52.
          Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$' Sub-task Closed Prasad Naidu Vemani
          53.
          Move the "true" string literal on the left side of this string comparison. Sub-task Closed Swapnali Pode
          54.
          Sonar Minor : Rename this local variable name to match the regular expression for AAI-esr-server Sub-task Closed Reddy Prasad Vemani
          55.
          Add a private constructor to hide the implicit public one. Sub-task Closed Swapnali Pode
          56.
          Rename this field to match the regular expression Sub-task Closed Reddy Prasad Vemani
          57.
          Either log or rethrow this exception Sub-task Closed Swapnali Pode
          58.
          Remove this useless assignment to local variable "messages". Sub-task Closed Swapnali Pode
          59.
          Add a private constructor Sub-task Closed Reddy Prasad Vemani
          60.
          Add a private constructor to hide the implicit public one Sub-task Closed Dushyant Thakur
          61.
          Remove this useless assignment to local variable result Sub-task Closed Swapnali Pode
          62.
          Renamed the local variable name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. Sub-task Closed Dushyant Thakur
          63.
          Replace "==" with "===" Sub-task Closed Reddy Prasad Vemani
          64.
          Either log or rethrow this exception. Sub-task Closed Swapnali Pode
          65.
          Replace "!=" with "!==" Sub-task Closed Reddy Prasad Vemani
          66.
          Replace "==" with "===" Sub-task Closed Reddy Prasad Vemani
          67.
          Replace "==" with "===" Sub-task Closed Reddy Prasad Vemani
          68.
          Either log or rethrow this exception Sub-task Closed Reddy Prasad Vemani
          69.
          Add the "@Override" annotation above this method signature Sub-task Closed Reddy Prasad Vemani
          70.
          Add a private constructor to hide the implicit public one Sub-task Closed Reddy Prasad Vemani
          71.
          This block of commented-out lines of code should be removed. Sub-task Closed Reddy Prasad Vemani
          72.
          Add the "@Override" annotation above this method signature Sub-task Closed Reddy Prasad Vemani
          73.
          Add the "@Override" annotation above this method signature Sub-task Closed Reddy Prasad Vemani
          74.
          Add the "@Override" annotation above this method signature Sub-task Closed Reddy Prasad Vemani
          75.
          Add the "@Override" annotation above this method signature Sub-task Closed Reddy Prasad Vemani
          76.
          Add the "@Override" annotation above this method signature Sub-task Closed Reddy Prasad Vemani
          77.
          Add the "@Override" annotation above this method signature Sub-task Closed Reddy Prasad Vemani
          78.
          Reorder the modifiers to comply with the Java Language Specification Sub-task Closed Reddy Prasad Vemani
          79.
          Reorder the modifiers to comply with the Java Language Specification Sub-task Closed Reddy Prasad Vemani
          80.
          Reorder the modifiers to comply with the Java Language Specification Sub-task Closed Reddy Prasad Vemani
          81.
          Reorder the modifiers to comply with the Java Language Specification Sub-task Closed Reddy Prasad Vemani
          82.
          Reorder the modifiers to comply with the Java Language Specification Sub-task Closed Reddy Prasad Vemani
          83.
          Reorder the modifiers to comply with the Java Language Specification Sub-task Closed Reddy Prasad Vemani
          84.
          Reorder the modifiers to comply with the Java Language Specification Sub-task Closed Reddy Prasad Vemani
          85.
          Reorder the modifiers to comply with the Java Language Specification Sub-task Closed Reddy Prasad Vemani
          86.
          Either log or rethrow this exception Sub-task Closed Reddy Prasad Vemani
          87.
          Either log or rethrow this exception Sub-task Closed Reddy Prasad Vemani
          88.
          Either log or rethrow this exception Sub-task Closed Reddy Prasad Vemani
          89.
          Replace the type specification in this constructor call with the diamond operator Sub-task Closed Reddy Prasad Vemani
          90.
          Replace type specification in constructor call with diamond operator Sub-task Closed Reddy Prasad Vemani
          91.
          Either log or rethrow this exception Sub-task Closed Reddy Prasad Vemani
          92.
          Fix AAIDmaapEventJMSConsumer architecture Sub-task Closed Bogumil Zebek
          93.
          Refactoring code smells in AbstractValidatingChampGraph Sub-task Closed Justyna Czestochowska
          94.
          Fix sonar issues in crud/logging/LoggingUtil Sub-task Closed Tomasz Switon
          95.
          Refactor of code smells in AAIMicroServiceAuthCore, ArtifactGenerator and GenerateArtifactsService Sub-task Closed Wiktor Garbarek
          96.
          Fix sonar issues in /crud/util/CrudProperties.java Sub-task Closed Tomasz Switon
          97.
          Fix sonar issues in /crud/service/CrudRestService Sub-task Closed Tomasz Switon
          98.
          Use a logger to log this exception. Sub-task Closed Adam Wudzinski
          99.
          Reduce code coupling in AAIDmaapEventJMSProducer Sub-task Closed Bogumil Zebek
          100.
          Refactor of code smells in NoOpTinkerPopTransaction Sub-task Closed Wiktor Garbarek
          101.
          Refactor of code smells in KafkaEventConsumer Sub-task Closed Wiktor Garbarek
          102.
          Refactor of code smells in KafkaEventPublisher Sub-task Closed Wiktor Garbarek
          103.
          Test coverage in GeneratorUtil Babel Sub-task Closed Adam Wudzinski
          104.
          Fix java code convention violation in traversal Sub-task Closed Adam Wudzinski
          105.
          Remove unusued imports in EdgeIngestor Sub-task Closed Wiktor Garbarek
          106.
          Fix bugs in Rest Client Sub-task Closed Wiktor Garbarek
          107.
          Fix bugs in Resources Sub-task Closed Wiktor Garbarek
          108.
          Fix minor clumsy sonar issues in traversal Sub-task Closed Adam Wudzinski
          109.
          Fix handling of InterruptedException in Champ Sub-task Closed Wiktor Garbarek
          110.
          Fix sonar issues Sub-task Closed Parshad Patel
          111.
          [SONAR] Fix "NullPointerException" violation Sub-task Closed Bogumil Zebek
          112.
          [SONAR] Fix stream closing Sub-task Closed Bogumil Zebek
          113.
          Remove broken, duplicated AbstractLoggingChampGraph class Sub-task Closed Bogumil Zebek
          114.
          OxmModelLoader code refactor + add missing tests Sub-task Closed Bogumil Zebek
          115.
          [DataRouterProperties] File stream was not closed properly Sub-task Closed Bogumil Zebek
          116.
          Fix sonar violation -> This class overrides "equals()" and should therefore also override "hashCode()" Sub-task Closed Bogumil Zebek
          117.
          Fix sonar violation "Make the enclosing method "static" or remove this set." Sub-task Closed Bogumil Zebek
          118.
          [aai-sparky-be] Fix potential "NullPointerException" cases Sub-task Closed Bogumil Zebek
          119.
          [aai-spark-be] Restore interrupted state Sub-task Closed Bogumil Zebek
          120.
          [aai-traversal] Fix potential NullPointerExceptions Sub-task Closed Bogumil Zebek
          121.
          [aai-champ] Fix sonar violation "condition always evaluate to true" Sub-task Closed Bogumil Zebek
          122.
          [aai- champ] Fix potential null pointer places Sub-task Closed Bogumil Zebek
          123.
          [aai-common] refactor of DataGrooming Sub-task Closed Justyna Czestochowska
          124.
          [aai-common] remove code smells from ManageJanusGraphSchema Sub-task Closed Justyna Czestochowska
          125.
          [aai-data-router] Fix class serialization Sub-task Closed Bogumil Zebek
          126.
          [aai-common] Fix sonar issues in SchemaGenerator Sub-task Closed Justyna Czestochowska
          127.
          [aai-spark-be] Refactor synchronizer classes: remove duplicated performRetrySync Sub-task Closed Bogumil Zebek
          128.
          [aai-aai-common] Improve code quality Sub-task Closed Bogumil Zebek
          129.
          [aai-common/aai-core] Fix sonar violation Sub-task Closed Arindam Mondal
          130.
          Fix Blocker sonar issues in AAIGraph.java Sub-task Closed Amaresh Kumar
          131.
          Fix sonar issues in sparky, search service, data-router and router-core Sub-task Closed Arul Nambi
          132.
          Sonar Critical: Use Logger and log the exception Sub-task Closed Shubhada Vaze
          133.
          Sonar fixes - Remove this useless assignment to local variable Sub-task Closed Driptaroop Das
          134.
          Sonar: Remove stacktrace and add error logger Sub-task Closed chandan Ghosh
          135.
          Sonar AAIAuthCore.java - Define a constant instead of duplicating this literal "AAI_4001" 3 times. Sub-task Closed Driptaroop Das
          136.
          Sonar - fix the list get call to retrieve correct value Sub-task Closed Driptaroop Das
          137.
          Sonar Fixes - VnfSearchQueryBuilder.java Sub-task Closed Driptaroop Das
          138.
          Sonar Remove stacktrace and add error logger Sub-task Closed chandan Ghosh
          139.
          Sonar vulnerability reported Sub-task Closed chandan Ghosh
          140.
          Sonar - Use try-with-resources or close this "MongoClient" in a "finally" clause. Sub-task Closed Driptaroop Das
          141.
          Need to add exception log Sub-task Closed chandan Ghosh
          142.
          Sonar Need to add nullcheck in graphadmin Sub-task Closed chandan Ghosh
          143.
          Method should not have too many parameter AAI-Traversal Sub-task Closed Arindam Mondal
          144.
          Fix sonar issue in aai-data-router Sub-task Closed Arindam Mondal
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              Assignee:
              jimmydot James Forsyth
              Reporter:
              aishkashyap Aishwarya Singh
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: