Uploaded image for project: 'Common Controller SDK'
  1. Common Controller SDK
  2. CCSDK-1929

Tests in pgaas always succeed

XMLWordPrintable

      Six tests in pgaas/tests/test_plugin swallow any exception which occurrs, merely printing it instead, even though the guarded code is supposed to succeed.

      Tests shall not do that, in order to properly indicate failures. Simply reraising the exception solves this.

      Two issues are revealed by doing this - wrong parameters being passed in test_update_database and (python3-only) hashlib.sha256 only works on bytes objects, not str (see attachments).

       

            mirlos mirlos
            mirlos mirlos
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: