Uploaded image for project: 'Configuration Persistence Service'
  1. Configuration Persistence Service
  2. CPS-2170

Reject Batch Read Requests when it is too big

XMLWordPrintable

      Additional performance requirement for existing batch-read

      NCMP shall limit 50 cmHandles per operation

      NCMP shall reject any request with over 50 cmHandles for any operation (number of operations is unlimited)

       

      Issues & Decisions

      1. Batch support multiple operations with multiple cm handles each!
        ecsakoc  agreed to reject request if ANY of the operations attempt to read more then 50 cm handles (confirmed 8 Apr by ecsakoc )
      2. Agree HTTP Status code
        ecsakoc agreed to use  413 Payload Too Large
      3. Developer issue: in what layer to handle/throw exception: REST controller OR service Layer ?!

      A/C

      1. Agree HTTP Error code when limit exceeded: 413 Payload Too Large  (Confirmed by ecsakoc )
      2. Update documentation
      3. Demo to team and stakeholders

      Out-of-scope

      1. Configurable limit, NCMP Hard-code the this limit as agreed with ecsakoc 

      How

      1. Introduce new (NCMP specific exception) e.g. OperationTooLargeException
      2. throw exception in org.onap.cps.ncmp.rest.controller.handlers.NcmpPassthroughResourceRequestHandler#validateDataOperationRequest (preferred)
      3. handle in NetworkCmProxyRestExceptionHandler.java and return 413
      4. documentation updates! (in the Yaml)

            ToineSiebelink Toine Siebelink
            mrade Kolawole Adebisi-Adeolokun
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: