Uploaded image for project: 'Data Collection, Analytics, and Events'
  1. Data Collection, Analytics, and Events
  2. DCAEGEN2-487

fix deployment-handler to avoid error 500 "value" argument is out of bounds on deployment

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Medium Medium
    • Beijing Release
    • Beijing Release
    • None

      deployment-handler crashes with

      TypeError: "value" argument is out of bounds
          at checkInt (buffer.js:1041:11)
          at Buffer.writeInt32LE (buffer.js:1231:5)
          at Object.entryHeaderToBinary (/opt/app/dh/node_modules/adm-zip/headers/entryHeader.js:216:18)
          at Object.packHeader (/opt/app/dh/node_modules/adm-zip/zipEntry.js:260:39)
          at /opt/app/dh/node_modules/adm-zip/zipFile.js:198:41
          at Array.forEach (native)
          at Object.compressToBuffer (/opt/app/dh/node_modules/adm-zip/zipFile.js:182:23)
          at Object.toBuffer (/opt/app/dh/node_modules/adm-zip/adm-zip.js:553:25)
          at Object.exports.uploadBlueprint (/opt/app/dh/lib/cloudify.js:9:10513)
          at Object.launchBlueprint (/opt/app/dh/lib/deploy.js:9:5851)
          at /opt/app/dh/lib/dcae-deployments.js:9:4786
          at process._tickCallback (internal/process/next_tick.js:109:7)

      Apparently, the latest version 0.4.9 of the adm-zip lib is broken when it calculates and saves the crc32.  Unfortunately, the package.json has "adm-zip": "^0.4.7", so the build brings the 0.4.9.  I am going to change that right away to point to 0.4.7. 

       The success rate on the unit tests of 0.4.9 is about 49% when I try to zip the list of strings that consist of numbers between ‘0’ and ‘0123456789’*10 (max length=100). 

       

      It works fine with the older version 0.4.7 of the adm-lib that is the original version for development – it is success all the time 100%.   

       

      for more info on the problem see the comment at https://github.com/cthackers/adm-zip/commit/5a280de6c28916bf9bbef7f5aa0ab4979e9d60f3

            alex_sh alex_sh
            alex_sh alex_sh
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: