Based on the comments from 91854 commit.
In the ValidationConfigManager and ReportManager:
- designed should be improved
- use the static variables in a more appropriate way.
Expected result
This should improve the way that this class is tested (not used powermock framework) and allow to future refactoring.
- blocks
-
SDC-2473 Investigate the option to remove powermock from asdctool
- Closed
1.
|
Remove static field props from ValidationConfigManager to improve design and testability | Closed | francistoth | |
2.
|
Remove static field csvReportFilePath from ValidationConfigManager to improve design and testability | Closed | francistoth | |
3.
|
Remove static field outputFullFilePath from ValidationConfigManager to improve design and testability | Closed | francistoth | |
4.
|
Encapsulate ReportManager's failedVerticesPerTask and resultsPerVertex in Report class | Closed | francistoth | |
5.
|
Decouple CSV Report file writing and formatting logic | Closed | francistoth | |
6.
|
Decouple TXT Report file writing and formatting logic | Closed | francistoth | |
7.
|
Clean up executor hierarchy | Closed | francistoth |