-
Task
-
Resolution: Done
-
Medium
-
None
-
None
As reported during code review, code of Test Topology Auto Design- Service Import
For the code of this review: https://gerrit.onap.org/r/c/sdc/+/112684
Code coverage must be increased as well as maintainability,
By maintainability, it means:
- Copy paste of existing methods must be replaced by common code. Resource/Service classes have a parent class Component. The code must use that class instead in the signature, no need to duplicate the code for that. All the existing code & tests have been unnecessarily duplicated.
- The methods having more than 30 lines must be split into smaller methods.
- The number of method parameters must be reduced
- Class with 6K lines of code must be split into smaller classes
- Sonar issues and ONAP checkstyle issues must be fixed.
- Test coverage must be improved, the last sonar test done on the code reported only 38% of coverage for that new code.
We are going to merge the first part but on the basis that code is going to be improved at minimum to not break coverage metrics.
Target sonar metric : line coverage to be above 55% as per release requirements
- relates to
-
SDC-3179 Support for Test Topology Auto Design- Service Import
- Closed