After successful instantiation of a Service including a single Network, the deletion of the Network fails with the error:
"AAI Query Success Response but 'vf-module' relationship exist, not allowed to delete: network Id: 73b3d37a-0ba8-4bdc-af33-21b3fb56ba43"

,which is not true (see AAI response below)

Reason (detected by Eric Multanen) is most likely a bug (missing "!") in bpmn/so-bpmn-infrastructure-common/src/main/groovy/org/onap/so/bpmn/infrastructure/scripts/DoDeleteNetworkInstance.groovy:

                if (relationships.isPresent()){
                 if(relationships.get().getRelatedAAIUris(AAIObjectType.VF_MODULE).isEmpty())

{                         execution.setVariable(Prefix + "isVfRelationshipExist", true)                         isVfRelationshipExist = true                         String relationshipMessage = "AAI Query Success Response but 'vf-module' relationship exist, not allowed to delete: network Id: " + networkId                         exceptionUtil.buildWorkflowException(execution, 2500, relationshipMessage)                     }

else
...

AAI response:

2019-06-25T12:00:23.986Z|d2907985-058f-4709-993d-7ed388e3f276| o.o.so.logging.jaxrs.filter.PayloadLoggingFilter - Response from GET: https://aai.onap:8443/aai/v15/network/l3-networks/l3-network/73b3d37a-0ba8-4bdc-af33-21b3fb56ba43?depth=all

Response Headers: {Content-Length=[2854], content-type=[application/json], Date=[Tue, 25 Jun 2019 12:00:23 GMT], Strict-Transport-Security=[max-age=16000000; includeSubDomains; preload;], vertex-id=[323816], X-AAI-TXID=[0-aai-resources-190625-12:00:23:943-28614]}{"network-id":"73b3d37a-0ba8-4bdc-af33-21b3fb56ba43","network-name":"purenetwork2-net-instance-net-internal_6JACOF","network-type":"Generic NeutronNet","network-role":"Purenetwork2.net-internal","network-technology":"NEUTRON","neutron-network-id":"959143e8-ba45-45a9-b058-7ed1254927fd","is-bound-to-vpn":false,"service-id":"39011997-5f21-435e-9b29-f71255ab2ee5","network-role-instance":0,"resource-version":"1561463988296","orchestration-status":"Active","heat-stack-id":"purenetwork2-net-instance-net-internal_6JACOF/fd524288-d5ca-49f0-91b0-7df6f632eb2e","is-provider-network":false,"is-shared-network":false,"is-external-network":(false,"subnets":{"subnet":[

{"subnet-id":"45a9d333-49aa-4a4b-bad7-13f39732a225","subnet-name":"net-internal-subnet","neutron-subnet-id":"5f1f98c9-055c-4068-8f3b-006922094816","gateway-address":"10.200.0.1","network-start-address":"10.200.0.0","cidr-mask":"24","ip-version":"4","orchestration-status":"Created","dhcp-enabled":false,"resource-version":"1561463988507"}

]},"relationship-list":{"relationship":[

{"*related-to":"service-instance*","relationship-label":"org.onap.relationships.inventory.ComposedOf","related-link":"/aai/v15/business/customers/customer/dtcustomer/service-subscriptions/service-subscription/net/service-instances/service-instance/1c307b0f-fac9-49aa-a491-693da8164b70","relationship-data":[\{"relationship-key":"customer.global-customer-id","relationship-value":"dtcustomer"}

,{"relationship-key":"service-subscription.service-type","relationship-value":"net"},{"relationship-key":"service-instance.service-instance-id","relationship-value":"1c307b0f-fac9-49aa-a491-693da8164b70"}],"related-to-property":[\{"property-key":"service-instance.service-instance-name","property-value":"purenetwork2-service-instance-6JACOF"}]},{"related-to":"cloud-region","relationship-label":"org.onap.relationships.inventory.Uses","related-link":"/aai/v15/cloud-infrastructure/cloud-regions/cloud-region/CloudOwner/RegionOne","relationship-data":[

{"relationship-key":"cloud-region.cloud-owner","relationship-value":("CloudOwner"}

,{"relationship-key":"cloud-region.cloud-region-id","relationship-value":"RegionOne"}],"related-to-property":[\{"property-key":"cloud-region.owner-defined-type","property-value":"t1"}]},

{"*related-to":"tenant*","relationship-label":"org.onap.relationships.inventory.Uses","related-link":"/aai/v15/cloud-infrastructure/cloud-regions/cloud-region/CloudOwner/RegionOne/tenants/tenant/acfb26688bde46f8b5677cb324b9e8c1","relationship-data":[\{"relationship-key":"cloud-region.cloud-owner","relationship-value":"CloudOwner"}

,{"relationship-key":"cloud-region.cloud-region-id","relationship-value":"RegionOne"},{"relationship-key":"tenant.tenant-id","relationship-value":"acfb26688bde46f8b5677cb324b9e8c1"}],"related-to-property":[\{"property-key":"tenant.tenant-name","property-value":"hp-onap-oom-ci"}]}]}}

SO error:

2019-06-25T12:00:23.994Z|d2907985-058f-4709-993d-7ed388e3f276| org.onap.so.bpmn.common.scripts.ExceptionUtil - Building a WorkflowException for DoDeleteNetworkInstance

2019-06-25T12:00:23.998Z|d2907985-058f-4709-993d-7ed388e3f276| org.onap.so.bpmn.common.scripts.ExceptionUtil - Outgoing WorkflowException is WorkflowException[processKey=DoDeleteNetworkInstance,errorCode=2500,errorMessage=AAI Query Success Response *but 'vf-module' relationship exist*, not allowed to delete: network Id: 73b3d37a-0ba8-4bdc-af33-21b3fb56ba43,workStep=*]

2019-06-25T12:00:23.998Z|d2907985-058f-4709-993d-7ed388e3f276| o.o.s.b.i.scripts.DoDeleteNetworkInstance - DELNWKI_isVfRelationshipExist - true

2019-06-25T12:00:23.999Z|d2907985-058f-4709-993d-7ed388e3f276| o.o.s.b.i.scripts.DoDeleteNetworkInstance -  AAI Query call, isAAIGood? : true

2019-06-25T12:00:24.008Z|d2907985-058f-4709-993d-7ed388e3f276| o.o.s.b.i.scripts.DoDeleteNetworkInstance - DELNWKI_WorkflowException - WorkflowException[processKey=DoDeleteNetworkInstance,errorCode=2500,errorMessage=AAI Query Success Response but 'vf-module' relationship exist, not allowed to delete: network Id: 73b3d37a-0ba8-4bdc-af33-21b3fb56ba43,workStep=*]