Uploaded image for project: 'Data Collection, Analytics, and Events'
  1. Data Collection, Analytics, and Events
  2. DCAEGEN2-3087

helm generator should use "log.path" rather than "logDirectory"

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Medium
    • Resolution: Done
    • Jakarta Release
    • Kohn Release
    • dcae-platform

    Description

      Following error noticed when chart linting is done before push to registry

      Deleting outdated charts
      2022-02-18 21:34:01.971  INFO 1 --- [nio-9090-exec-8] o.o.d.p.h.chartbuilder.HelmClientImpl    : running: helm lint /tmp/chart17782661275132687085
      2022-02-18 21:34:04.493  INFO 1 --- [nio-9090-exec-8] o.o.d.p.h.chartbuilder.HelmClientImpl    : ==> Linting /tmp/chart17782661275132687085
      2022-02-18 21:34:04.494  INFO 1 --- [nio-9090-exec-8] o.o.d.p.h.chartbuilder.HelmClientImpl    : [INFO] Chart.yaml: icon is recommended
      2022-02-18 21:34:04.494  INFO 1 --- [nio-9090-exec-8] o.o.d.p.h.chartbuilder.HelmClientImpl    : [ERROR] templates/: template: dcae-ves-collector/templates/deployment.yaml:1:3: executing "dcae-ves-collector/templates/deployment.yaml" at <include "dcaegen2-services-common.microserviceDeployment" .>: error calling include: template: dcae-ves-collector/charts/dcaegen2-services-common/templates/_deployment.tpl:225:34: executing "dcaegen2-services-common.microserviceDeployment" at <.Values.log.path>: nil pointer evaluating interface {}.path
      2022-02-18 21:34:04.494  INFO 1 --- [nio-9090-exec-8] o.o.d.p.h.chartbuilder.HelmClientImpl    :
      2022-02-18 21:34:04.502 ERROR 1 --- [nio-9090-exec-8] o.o.d.r.c.h.HelmChartGeneratorClientImpl : Error occurred while running helm command.java.lang.RuntimeException: Error occurred while running helm command.
              at org.onap.dcaegen2.platform.helmchartgenerator.chartbuilder.HelmClientImpl.assertExitCode(HelmClientImpl.java:154) ~[helmchartgenerator-core-1.0.2-SNAPSHOT.jar!/:na]
              at org.onap.dcaegen2.platform.helmchartgenerator.chartbuilder.HelmClientImpl.runProcess(HelmClientImpl.java:112) ~[helmchartgenerator-core-1.0.2-SNAPSHOT.jar!/:na]
              at org.onap.dcaegen2.platform.helmchartgenerator.chartbuilder.HelmClientImpl.lint(HelmClientImpl.java:76) ~[helmchartgenerator-core-1.0.2-SNAPSHOT.jar!/:na]
              at org.onap.dcaegen2.platform.helmchartgenerator.chartbuilder.ChartGenerator.generate(ChartGenerator.java:75) ~[helmchartgenerator-core-1.0.2-SNAPSHOT.jar!/:na]
              at org.onap.dcaegen2.platform.helmchartgenerator.chartbuilder.ChartBuilder.build(ChartBuilder.java:72) ~[helmchartgenerator-core-1.0.2-SNAPSHOT.jar!/:na]
              at org.onap.dcae.runtime.core.helm.HelmChartGeneratorClientImpl.generateHelmChart(HelmChartGeneratorClientImpl.java:65) ~[runtime-core-1.3.1.jar!/:na]
              at org.onap.dcae.runtime.web.service.GraphServiceHelmProxy.createHelmCharts(GraphServiceHelmProxy.java:96) ~[classes!/:na]
              at org.onap.dcae.runtime.web.service.GraphServiceHelmProxy.distribute(GraphServiceHelmProxy.java:86) ~[classes!/:na]
              at org.onap.dcae.runtime.web.controllers.GraphController.distributeGraph(GraphController.java:79) ~[classes!/:na]
              at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:na]
              at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[na:na]
              at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[na:na]
              at java.base/java.lang.reflect.Method.invoke(Unknown Source) ~[na:na]
              at org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:190) ~[spring-web-5.1.9.RELEASE.jar!/:5.1.9.RELEASE]
              at org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:138) ~[spring-web-5.1.9.RELEASE.jar!/:5.1.9.RELEASE]
              at org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:104) ~[spring-webmvc-5.1.9.RELEASE.jar!/:5.1.9.RELEASE]
              at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:892) ~[spring-webmvc-5.1.9.RELEASE.jar!/:5.1.9.RELEASE]
      
      

      The error is due to 1) recent dcaegen2-service template change which is expecting new parameter - .Values.log.path to be set (cannot be null) - This will be addressed in DCAEGEN2-3093

      The helm generator should use "log.path" rather than "logDirectory" when it generates the values.yaml for a chart, if the microservice is writing logs to a directory (and not to stdout/stderr). Scope of this Jira will be address this item.

      Attachments

        Issue Links

          # Subject Branch Project Status CR V

          Activity

            People

              vv770d Vijay Venkatesh Kumar
              vv770d Vijay Venkatesh Kumar
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: