It seems this codebase has gotten away from its original intention.

1) The model-actors should be utilizing the service loader functionality first created. Care should be taken to design the service loader application to support generic methods for initiating API calls either by Dmaap or REST. No static methods should be exposed as public.

2) The model-impl code also seems to haphazardly have static calls and stuff A&AI calls within the code. A&AI calls should be made outside any of the actor code. Any PDP engine should supply proper A&AI objects to both the actors/model-impl code.

Need some consistency in the codebase.

NOTE: Missing SDNC simulator test

NOTE: Should pass request id (if applicable) - the guard does not do this and should

NOTE: Guard should return error message if the API call fails. Right now it is only passing a string of Permit or Deny

NOTE: Delete any guard code that copy/pastes guard yaml to a policy. Obviously never used anywhere.

NOTE: timeout values missing or 0 (more for drools rules clean up)

• With this review, if it's left out of the yaml, or set to zero in the yaml, then the default value from the rules (currently 1500s) will be used. Thus the only way it can be set to zero is if the rules, themselves, specify null or zero (which is currently not the case in the rules ONAP provides) AND the yaml does the same.