Uploaded image for project: 'Policy Framework'
  1. Policy Framework
  2. POLICY-336

Address Technical Debt

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Done
    • Icon: Medium Medium
    • Beijing Release
    • None
    • None
    • None

      As an ONAP Developer, I wish to pare down the technical debt identified by sonar.

      Please NOTE, this work is not to be done until post-Amsterdam release.

      Acceptable fixes will be only the following:

      • Replace this usage of System.out or System.err by a logger (Most likely these should be deleted if there already is a logging statement)
      • Move the XXXX string literal on the left side of this string comparison.
      • Introduce a new variable instead of reusing the parameter
      • The type of the "keySet" object should be an interface such as "Set" rather than the implementation "HashSet" (Applies to Map/HashMap as well)
      • Add a nested comment explaining why this method is empty (Due to empty constructors, which Sonar complains that need to be there.)
      • Remove this useless assignment to local variable 
      • Remove those useless parentheses
      • Use isEmpty() to check whether the collection is empty or not
      • Change this "try" to a try-with-resources.
      • Replace the type specification in this constructor call with the diamond operator ("<>").
      • Add the "@Override" annotation above this method signature
      • Remove unused imports
      • Unused values/fields/local variables
      • Type safety: The expression of type HashMap needs unchecked conversion to conform to Map<String,String>
      • The serializable class URLEntry does not declare a static final serialVersionUID field of type long

       

        1.
        		 Resolve JavaScript Code issues Sub-task Closed rb7147
        2.
        		 policy/drools-applications Sub-task Closed liamfallon
        3.
        		 policy/common integrity-audit submodule Sub-task Closed pdragosh
        4.
        		 policy/common integrity-monitor submodule Sub-task Closed pdragosh
        5.
        		 policy/common ONAP-logging Sub-task Closed cc847m
        6.
        		 policy/common site-manager submodule Sub-task Closed Unassigned
        7.
        		 policy/drools-pdp policy-utils Sub-task Closed pdragosh
        8.
        		 policy/drools-pdp policy-core Sub-task Closed cc847m
        9.
        		 policy/drools-pdp policy-endpoints submodule Sub-task Closed dm741q
        10.
        		 policy/drools-pdp policy-management submodule Sub-task Closed Unassigned
        11.
        		 policy/drools-pdp feature-healthcheck submodule Sub-task Closed dm741q
        12.
        		 policy/drools-pdp feature-eelf submodule Sub-task Closed Unassigned
        13.
        		 policy/drools-pdp feature-session-persistence submodule Sub-task Closed Unassigned
        14.
        		 policy/drools-pdp feature-test-transaction submodule Sub-task Closed dm741q
        15.
        		 policy/drools-pdp api-state-management submodule Sub-task Closed jrh3
        16.
        		 policy/drools-pdp feature-state-management submodule Sub-task Closed jrh3
        17.
        		 policy/drools-pdp api-active-standby-management Sub-task Closed Unassigned
        18.
        		 policy/drools-pdp feature-active-standby-management Sub-task Closed Unassigned
        19.
        		 policy/engine BRMSGateway submodule Sub-task Closed dc443y
        20.
        		 policy/engine LogParser submodule Sub-task Closed Unassigned
        21.
        		 policy/engine PolicyEngineUtils Sub-task Closed pdragosh
        22.
        		 policy/engine ONAP-XACML submodule Sub-task Closed cgao
        23.
        		 policy/engine ONAP-REST submodule Sub-task Closed ankit7453
        24.
        		 policy/engine PolicyEngineAPI submodule Sub-task Closed pdragosh
        25.
        		 policy/engine ONAP-PDP submodule Sub-task Closed Unassigned
        26.
        		 policy/engine ONAP-PDP-REST submodule Sub-task Closed Unassigned
        27.
        		 policy/engine ONAP-PAP-REST submodule Sub-task Closed Unassigned
        28.
        		 policy/engine PolicyEngineClient submodule Sub-task Closed Unassigned
        29.
        		 policy/engine POLICY-SDK-APP submodule Sub-task Closed pdragosh
        30.
        		 policy/engine ONAP-SDK-APP submodule Sub-task Closed Unassigned
        31.
        		 Resolve policy/engine CRITICAL Sub-task Closed pdragosh
        32.
        		 Clean up policy/common policy/drools-pdp usage of generic Exception Sub-task Closed jrh3
        33.
        		 Replace this use of System.out or System.err by a logger Sub-task Closed swapnalipode
        34.
        		 Make "drlRuleAndUIParams" transient or serializable Sub-task Closed swapnalipode
        35.
        		 Replace System.out or System.err by logger Sub-task Closed swapnalipode
        36.
        		 Replace this use of System.out or System.err by a logger Sub-task Closed swapnalipode
        37.
        		 Make "responseHistoryList" private or transient. Sub-task Closed swapnalipode
        38.
        		 Make "pgStream" private or transient. Sub-task Closed swapnalipode
        39.
        		 Policy Major:Local variables should not shadow class field Sub-task Closed manamohan
        40.
        		 Sonar :Blocker Sub-task Closed manamohan
        41.
        		 Replace this use of System.out or System.err by a logger Sub-task Closed swapnalipode
        42.
        		 Remove this useless assignment to local variable "xMessage" Sub-task Closed swapnalipode
        43.
        		 Remove this useless assignment to local variable em Sub-task Closed swapnalipode
        44.
        		 Remove this useless assignment to local variable "temp" Sub-task Closed swapnalipode
        45.
        		 Sonar:Blocker:Use try-with-resources or close this "FileWriter" in a "finally" clause. Sub-task Closed manamohan
        46.
        		 Move the "null" string literal on the left side of this string comparison Sub-task Closed swapnalipode
        47.
        		 Merge this if statement with the enclosing one Sub-task Closed swapnalipode
        48.
        		 Use try-with-resources or close this "BufferedWriter" in a "finally" clause. Sub-task Closed swapnalipode
        49.
        		 Sonar Blocker:Use try-with-resources or close this "JarFile" in a "finally" clause. Sub-task Closed manamohan
        50.
        		 Move the GUARD_BL_YAML string literal on the left side of this string comparison Sub-task Closed swapnalipode
        51.
        		 Move the "api" string literal on the left side of this string comparison Sub-task Closed swapnalipode

            pdragosh pdragosh
            pdragosh pdragosh
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: