Uploaded image for project: 'Policy Framework'
  1. Policy Framework
  2. POLICY-336

Address Technical Debt

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Done
    • Icon: Medium Medium
    • Beijing Release
    • None
    • None
    • None

      As an ONAP Developer, I wish to pare down the technical debt identified by sonar.

      Please NOTE, this work is not to be done until post-Amsterdam release.

      Acceptable fixes will be only the following:

      • Replace this usage of System.out or System.err by a logger (Most likely these should be deleted if there already is a logging statement)
      • Move the XXXX string literal on the left side of this string comparison.
      • Introduce a new variable instead of reusing the parameter
      • The type of the "keySet" object should be an interface such as "Set" rather than the implementation "HashSet" (Applies to Map/HashMap as well)
      • Add a nested comment explaining why this method is empty (Due to empty constructors, which Sonar complains that need to be there.)
      • Remove this useless assignment to local variable 
      • Remove those useless parentheses
      • Use isEmpty() to check whether the collection is empty or not
      • Change this "try" to a try-with-resources.
      • Replace the type specification in this constructor call with the diamond operator ("<>").
      • Add the "@Override" annotation above this method signature
      • Remove unused imports
      • Unused values/fields/local variables
      • Type safety: The expression of type HashMap needs unchecked conversion to conform to Map<String,String>
      • The serializable class URLEntry does not declare a static final serialVersionUID field of type long

       

        There are no Sub-Tasks for this issue.

            pdragosh pdragosh
            pdragosh pdragosh
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: